Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.95%. Comparing base (58b49f2) to head (0fbccf4).
⚠️ Report is 3 commits behind head on main.

@@           Coverage Diff           @@
##             main    #7879   +/-   ##
=======================================
  Coverage   92.94%   92.95%           
=======================================
  Files         116      116           
  Lines       18845    18857   +12     
=======================================
+ Hits        17516    17528   +12     
  Misses       1329     1329           

Hi @jessegrabowski , could you please give this a review when you have a moment ? Thank you 🙏

Hi @ricardoV94 , sorry, was wondering if you could offer some comments, will get me unstuck. Thank you 🙏

I left a comment in #7713 (comment)

I don't have enough knowledge to say whether we should add this feature

Hey @asifzubair, resharing the link @ricardoV94 shared on improper distribution sampling.

Are you able to add a test to meet @jessegrabowski's criteria?

To merge the PR, I would want to see that the prior and the no-data MCMC gives the same answer

@theorashid feel free to comment. Given these challenges of improper priors, do you think ICAR is better left to the wonderful world of INLA?

Thank you, @ColtAllen , for your reply

Are you able to add a test to meet @jessegrabowski's criteria?

I can surely work on this. The requirement is a bit hazy, tbh, but it usually clears up once I start looking at it closely.

The reason I stopped working on this PR was I wasn't sure if we are still interested pursuing this. If we are, I'm happy to keep pushing. Please let me know. 🙏